hrm, something seems to be up with our `build_wind...
# cores
sharvil
10/20/2023, 3:03 PMhrm, something seems to be up with our
build_windows (Release, 64, windows-2019)s
Stefano Bonicatti
10/20/2023, 3:06 PMYeah, you can see the logs here: https://github.com/osquery/osquery/actions/runs/6580446321/job/17891880341?pr=8166#step:21:663
s
sharvil
10/20/2023, 3:07 PMYeah, it’s failing on master and other PRs too — https://github.com/osquery/osquery/actions/runs/6564750568/job/17831819185
sharvil
10/20/2023, 3:07 PMs
Stefano Bonicatti
10/20/2023, 3:08 PMit's the python http test server that is using a deprecated way (and now apparently removed in python 3.12) of creating a SSL context
s
sharvil
10/20/2023, 3:08 PMoof
s
Stefano Bonicatti
10/20/2023, 3:08 PMthe warning that
ssl.wrap_socketStefano Bonicatti
10/20/2023, 3:09 PMwell, the alternative is already present https://docs.python.org/3/library/ssl.html
Stefano Bonicatti
10/20/2023, 3:09 PM Copy code
For more sophisticated applications, the ssl.SSLContext class helps manage settings and certificates, which can then be inherited by SSL sockets created through the SSLContext.wrap_socket() method.Stefano Bonicatti
10/20/2023, 3:10 PMthat's the substitute that should be used
ty 1
s
sharvil
10/20/2023, 3:40 PMsuper duper quick attempt at fixing it: https://github.com/osquery/osquery/pull/8169 (my python is a bit weak these days)
🎉 1
4 Views