Title
#code-review
puffycid

puffycid

06/23/2021, 7:50 PM
Could someone review the PR at https://github.com/osquery/osquery/pull/7160 And let me know if there r any changes that need to be done? I think all comments so far should have been addressed
s

seph

06/29/2021, 2:16 PM
The CI build failure on windows looks real
sccache.exe C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ALL_NO_LIB -DBOOST_ALL_STATIC_LINK -DLIEF_STATIC -DNDEBUG -DNOMINMAX -DNTDDI_VERSION=NTDDI_WIN7 -D_WIN32_WINNT=_WIN32_WINNT_WIN7 -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\src\PE\utils\ordinals_lookup_tables -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\src\PE\utils\ordinals_lookup_tables_std -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\src\PE\signatures -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\config\lief -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\include -ID:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\src -ID:\a\osquery\osquery\w\src\libraries\cmake\source\mbedtls\src\include -ID:\a\osquery\osquery\w\src\libraries\cmake\source\spdlog\src\include /DWIN32 /D_WINDOWS /GR /EHs /O2 /Ob2 /DNDEBUG -MT   /FIiso646.h /Ot /guard:cf /bigobj /Zc:inline- /W0 -std:c++17 /showIncludes /Folibs\src\lief\CMakeFiles\thirdparty_lief.dir\src\src\Object.cpp.obj /Fdlibs\src\lief\CMakeFiles\thirdparty_lief.dir\thirdparty_lief.pdb /FS -c D:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\src\Object.cpp
D:\a\osquery\osquery\w\src\libraries\cmake\source\lief\src\include\LIEF/Visitor.hpp(27): fatal error C1083: Cannot open include file: 'LIEF/config.h': No such file or directory
puffycid

puffycid

06/29/2021, 3:18 PM
Weird it compiles fine on my VM I can try to see if there something I need to fix