happy to help with figuring out what breaks once you push the commits to the repo
11/14/2018, 9:56 PM
Awesome, that will be helpful.
11/14/2018, 9:59 PM
@fmanco one last question. the phabricator instance, is it public? can we see your code review there?
i contribute to Go, and they use something similar with gerrit, where prs are mirrored, but the code review is on gerrit. that works mostly fine because the process is fully public
11/14/2018, 10:10 PM
Unfortunately our Phabricator instance isn't public, so you won't be able to see our code review. Visibility into our code review is something we discussed and would like to give but currently don't have a solution for. To keep a good level of transparency we'll ensure that the commit messages are descriptive, and that we'll still do Blueprints for discussing major changes.
11/14/2018, 10:12 PM
how does discussion work, with github
if you want me to address changes for my PR
does ShipIt sync things? or do you just have two discussions?
11/14/2018, 10:19 PM
Ah, for PRs we will do the review fully on GitHub, so the current process will basically remain.
11/14/2018, 10:20 PM
how do we give you feedback on changes you make? are you opening PRs too? or are we going to start seeing commits which we were not able to review
11/14/2018, 10:24 PM
On the individual commits there won't be a chance to give feedback. At least initially. For major changes we'll open Blueprints and feedback is given on the issue on GitHub.