Title
#general
g

groob

11/14/2018, 9:51 PM
@fmanco what will it look like for someone outside FB to build osquery from source
fmanco

fmanco

11/14/2018, 9:51 PM
Basically something like
buck build osquery:osqueryd
g

groob

11/14/2018, 9:52 PM
is it a local build? does it need remote hosts?
fmanco

fmanco

11/14/2018, 9:52 PM
There might be some setup required as we're not going to package the toolchain as a dependency anymore. We'll provide scripts to setup the host, but if you have a toolchain that should also work.
9:53 PM
All it needs is access to S3 to download pre-built dependencies. The rest is all local.
g

groob

11/14/2018, 9:53 PM
will you guys write up how to do that?
fmanco

fmanco

11/14/2018, 9:54 PM
We'll update the provisioning scripts. It might not all be done with the first commit but we'll work with the community to try to support at least the major OSes/distros.
g

groob

11/14/2018, 9:54 PM
Okay
9:54 PM
looking forward to office hours tomorrow
fmanco

fmanco

11/14/2018, 9:54 PM
So to correct my answer above is more like
./tools/provision.sh
and then buck
g

groob

11/14/2018, 9:55 PM
happy to help with figuring out what breaks once you push the commits to the repo
fmanco

fmanco

11/14/2018, 9:56 PM
Awesome, that will be helpful.
g

groob

11/14/2018, 9:59 PM
@fmanco one last question. the phabricator instance, is it public? can we see your code review there?
9:59 PM
i contribute to Go, and they use something similar with gerrit, where prs are mirrored, but the code review is on gerrit. that works mostly fine because the process is fully public
fmanco

fmanco

11/14/2018, 10:10 PM
Unfortunately our Phabricator instance isn't public, so you won't be able to see our code review. Visibility into our code review is something we discussed and would like to give but currently don't have a solution for. To keep a good level of transparency we'll ensure that the commit messages are descriptive, and that we'll still do Blueprints for discussing major changes.
g

groob

11/14/2018, 10:12 PM
how does discussion work, with github
10:13 PM
if you want me to address changes for my PR
10:13 PM
does ShipIt sync things? or do you just have two discussions?
fmanco

fmanco

11/14/2018, 10:19 PM
Ah, for PRs we will do the review fully on GitHub, so the current process will basically remain.
g

groob

11/14/2018, 10:20 PM
how do we give you feedback on changes you make? are you opening PRs too? or are we going to start seeing commits which we were not able to review
fmanco

fmanco

11/14/2018, 10:24 PM
On the individual commits there won't be a chance to give feedback. At least initially. For major changes we'll open Blueprints and feedback is given on the issue on GitHub.